UX: Fix more-topics tabs interaction with --space
#34047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing `--space` css var would result in incorrect size of the tabs and wrong placement of the border: The implementation isn't ideal, there are sub-pixel height differences between the tabs and table header cells, but it's difficult to match `display: block/flex` and `display: table-cell`. --- This also removes sizing down the font size on smaller screens. (the smaller font looked out of place between other, larger sized UI elements)
|
cc: @discourse/designers |
awesomerobot
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
--spacecss var would result in incorrect size of the tabs and wrong placement of the border:The implementation isn't ideal, there are sub-pixel height differences between the tabs and table header cells, but it's difficult to match
display: block/flexanddisplay: table-cell.This also removes sizing down the font size on smaller screens. (the smaller font looked out of place between other, larger sized UI elements)