FEATURE: Localize topic titles in notifications and bookmarks #34059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
reviewed
Aug 5, 2025
| end | ||
|
|
||
| def fancy_title | ||
| f = _topic.fancy_title |
There was a problem hiding this comment.
understand this is lift-and-shift existing logic but should we handle the case where _topic is nil? I see that we do that in include_fancy_title?
There was a problem hiding this comment.
There shouldn't be a need, the topic is a must-have in places where the serializer is used. The fancy title shouldn't be sent if include_ is false.
tyb-talks
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localizes topic titles in these areas
This PR also updates the user notification bookmark list to use fancy title instead of title, similar to the other user notification tabs.