FIX: Don't force user-selectable on Horizon's default color palettes #34062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/bug-s-with-color-palettes-and-light-dark-mode-switcher/377013/8 |
lis2
reviewed
Aug 6, 2025
| @@ -113,6 +113,7 @@ def self.update_theme( | |||
| ) | |||
| existing = false | |||
| end | |||
| theme.has_just_been_created = !existing | |||
There was a problem hiding this comment.
Your solution works, but it is a bit complex. Update of theme is setting has_just_been_created which is later used by SystemThemesManager.
What would you say if instead, we would hook directly here:
https://github.com/discourse/discourse/blob/main/db/fixtures/600_themes.rb#L5
I am thinking about something like SystemThemesManager.sync!(has_just_been_created: !theme_exists)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have logic that ensures Horizon's default palettes are marked as user-selectable each time the server boots up (i.e. on deploy), even if an admin has previously chosen to remove the user-selectable status on those palettes. We should respect the admin's choice, so this PR amends that logic so it only marks the palettes user-selectable when Horizon is first installed.
Internal topic: t/160291.