Skip to content

UX: Introduce shadow variables #34151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more
  • Loading branch information
jordanvidrine committed Aug 7, 2025
commit faedb5c724aef16a2e77f6eb3cdd4f3184a2fbd4
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ export default class ToolbarPopupmenuOptions extends Component {
@icon={{this.getIcon option}}
@action={{fn this.onSelect option}}
data-name={{option.name}}
class={{concatClass (if (this.getActive option) "--active")}}
class={{concatClass
(if (this.getActive option) "--active")
"btn-transparent"
}}
/>
</dropdown.item>
{{/each}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ export default class TopicAdminMenu extends Component {
@label="topic.actions.multi_select"
@action={{fn this.onButtonAction "toggleMultiSelect"}}
@icon="list-check"
class="btn-transparent"
/>
</dropdown.item>
{{/if}}
Expand All @@ -123,7 +124,7 @@ export default class TopicAdminMenu extends Component {
@label="topic.actions.delete"
@action={{fn this.onButtonAction "deleteTopic"}}
@icon="trash-can"
class="popup-menu-btn-danger btn-danger"
class="popup-menu-btn-danger btn-danger btn-transparent"
/>
</dropdown.item>
{{else if this.canRecover}}
Expand All @@ -132,6 +133,7 @@ export default class TopicAdminMenu extends Component {
@label="topic.actions.recover"
@action={{fn this.onButtonAction "recoverTopic"}}
@icon="arrow-rotate-left"
class="btn-transparent"
/>
</dropdown.item>
{{/if}}
Expand All @@ -153,6 +155,7 @@ export default class TopicAdminMenu extends Component {
}}
@action={{fn this.onButtonAction "toggleClosed"}}
@icon={{if @topic.closed "topic.opened" "topic.closed"}}
class="btn-transparent"
/>
</dropdown.item>
{{/if}}
Expand All @@ -173,6 +176,7 @@ export default class TopicAdminMenu extends Component {
}}
@action={{fn this.onButtonAction "showFeatureTopic"}}
@icon="thumbtack"
class="btn-transparent"
/>
</dropdown.item>
{{/if}}
Expand All @@ -189,6 +193,7 @@ export default class TopicAdminMenu extends Component {
}}
@action={{fn this.onButtonAction "toggleArchived"}}
@icon="folder"
class="btn-transparent"
/>
</dropdown.item>
{{/if}}
Expand All @@ -203,6 +208,7 @@ export default class TopicAdminMenu extends Component {
}}
@action={{fn this.onButtonAction "toggleVisibility"}}
@icon={{if this.visible "far-eye-slash" "far-eye"}}
class="btn-transparent"
/>
</dropdown.item>
{{/if}}
Expand All @@ -215,6 +221,7 @@ export default class TopicAdminMenu extends Component {
"topic.actions.make_public"
"topic.actions.make_private"
}}
class="btn-transparent"
@action={{fn
this.onButtonAction
(if
Expand All @@ -236,6 +243,7 @@ export default class TopicAdminMenu extends Component {
@label="topic.actions.timed_update"
@action={{fn this.onButtonAction "showTopicTimerModal"}}
@icon="far-clock"
class="btn-transparent"
/>
</dropdown.item>

Expand All @@ -245,6 +253,7 @@ export default class TopicAdminMenu extends Component {
@label="topic.change_timestamp.title"
@action={{fn this.onButtonAction "showChangeTimestamp"}}
@icon="calendar-days"
class="btn-transparent"
/>
</dropdown.item>
{{/if}}
Expand All @@ -254,6 +263,7 @@ export default class TopicAdminMenu extends Component {
@label="topic.actions.reset_bump_date"
@action={{fn this.onButtonAction "resetBumpDate"}}
@icon="anchor"
class="btn-transparent"
/>
</dropdown.item>

Expand All @@ -262,6 +272,7 @@ export default class TopicAdminMenu extends Component {
@label="topic.actions.slow_mode"
@action={{fn this.onButtonAction "showTopicSlowModeUpdate"}}
@icon="hourglass-start"
class="btn-transparent"
/>
</dropdown.item>
{{/if}}
Expand All @@ -275,6 +286,7 @@ export default class TopicAdminMenu extends Component {
@label="review.moderation_history"
@href={{this.topicModerationHistoryUrl}}
@icon="list"
class="btn-transparent"
/>
</dropdown.item>
{{/if}}
Expand Down
1 change: 1 addition & 0 deletions app/assets/stylesheets/admin/search.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
outline: none !important;
background: none !important;
width: 100% !important;
box-shadow: none !important;
}
}

Expand Down
1 change: 1 addition & 0 deletions app/assets/stylesheets/common/base/discourse.scss
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ input {
border: var(--d-input-border);
border-radius: var(--d-input-border-radius);
color-scheme: var(--scheme-type);
box-shadow: var(--d-box-shadow);

&:focus {
@include default-focus;
Expand Down
1 change: 1 addition & 0 deletions app/assets/stylesheets/common/base/new-user.scss
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@

.new-user-wrapper {
.user-navigation {
--d-box-shadow: none;
--user-navigation__border-width: 4px;
border-bottom: 1px solid var(--content-border-color);

Expand Down
1 change: 1 addition & 0 deletions app/assets/stylesheets/common/base/sidebar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,7 @@
width: 100%;
height: var(--d-sidebar-row-height);
cursor: pointer;
box-shadow: none;

&:focus {
outline: none;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
.search-term__input {
min-width: 0;
flex: 1 1;
box-shadow: none;
}
}

Expand Down
3 changes: 2 additions & 1 deletion app/assets/stylesheets/common/select-kit/combo-box.scss
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@

.select-kit-header {
background: var(--secondary);
border-color: var(--primary-400);
border-color: var(--input-border-color);
box-shadow: var(--d-box-shadow);

&.is-focused {
@include default-focus;
Expand Down