FEATURE: support GPT-5 #34168
Merged
FEATURE: support GPT-5 #34168
+75
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds mappings for Claude on AWS - ensures developer message is used - ensures we do the max token remapping needed - ensures reasoning effort is passed along
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
lis2
approved these changes
Aug 8, 2025
| ( | ||
| llm_model.name.start_with?("o1") || llm_model.name.start_with?("o3") || | ||
| llm_model.name.start_with?("gpt-5") | ||
| ) |
There was a problem hiding this comment.
it would be nice to have REASONING_MODEL_PREFIX_LIST. Just ultra NIT improvement
| @@ -14,7 +14,7 @@ def normalize_model_params(model_params) | |||
| # max_tokens is deprecated however we still need to support it | |||
| # on older OpenAI models and older Azure models, so we will only normalize | |||
| # if our model name starts with o (to denote all the reasoning models) | |||
| if llm_model.name.starts_with?("o") | |||
| if llm_model.name.starts_with?("o") | llm_model.name.starts_with?("gpt-5") | |||
There was a problem hiding this comment.
Then that magic const can be used here as well
There was a problem hiding this comment.
Cool yeah will follow up next week
pento
pushed a commit
that referenced
this pull request
Aug 11, 2025
Also adds mappings for Claude on AWS - ensures developer message is used - ensures we do the max token remapping needed - ensures reasoning effort is passed along
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/weekly-summary-of-ai-topics/293532/81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds mappings for Claude on AWS