Fixed #35924 -- Removed icons from the Select/Remove all buttons in the FilteredSelectMultiple widget. #19699
Conversation
| <use xlink:href="#clearall" x="0" y="4096" fill="#666666" /> | ||
| <use xlink:href="#clearall" x="0" y="4608" fill="#447e9b" /> | ||
| <use xlink:href="#chooseall" x="0" y="5120" fill="#666666" /> | ||
| <use xlink:href="#chooseall" x="0" y="5632" fill="#447e9b" /> | ||
| </svg> |
There was a problem hiding this comment.
We can crop the svg, something like:
--- a/django/contrib/admin/static/admin/img/selector-icons.svg
+++ b/django/contrib/admin/static/admin/img/selector-icons.svg
@@ -1,4 +1,4 @@
-<svg width="16" height="192" viewBox="0 0 512 6144" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+<svg width="16" height="128" viewBox="0 0 512 4096" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<!--!Font Awesome Free 6.7.2 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free Copyright 2025 Fonticons, Inc.-->There was a problem hiding this comment.
I missed this part! Thank you.
| --selector-button-bg: #e9e9ed; | ||
| --selector-button-fg: #525252; | ||
| --selector-button-hover-bg: #d0d0d7; |
There was a problem hiding this comment.
Instead of defining new styling, I think it might be worth reusing the existing button styling:
Notice that there is a "Reset password" button, I think we can have consistent styling with this (using --button-bg and not bold text).
Folks then have less button variations to learn, and if we make accessibility improvements to buttons, we have less variations to worry about
The @django/accessibility team might have an opinion here
There was a problem hiding this comment.
Yes, I initially considered that approach as well.
However, since that button is not a link, I thought it might be better to style it differently, so I added a separate style.
That said, this is just my personal opinion, and I believe it wouldn’t be a problem to reuse the same style.
…he FilteredSelectMultiple widget.
128f340 to
4b6e508
Compare
Trac ticket number
ticket-35924
Branch description
continue PR...
Thank you for working on this ticket @ajosephau ⭐️
Removed the icons used in the Select/Remove all buttons of the
FilteredSelectMultiplewidget.Before
After
Checklist
mainbranch.