Fix 29291 negated q when expression #19712
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-29291
Branch description
This PR fixes a long-standing issue where using a negated Q() object inside a When() expression would result in incorrect SQL due to improper join handling across nullable relationships.
Previously, annotations like:
would generate broken or incomplete SQL when traversing nullable FKs. This patch updates When.as_sql() to delegate condition compilation to the query's internal _add_q() logic using query.build_filter(...), ensuring consistent handling of negation, joins, and subquery pushdowns -- just like .filter().
This patch includes:
Checklist
main
branch.