Skip to content

Fixed #36543 -- French Canadian locale formats times incorrectly. #19716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed #36543 -- French Canadian locale formats times incorrectly. #19716

wants to merge 1 commit into from
+41 −3

Conversation

mriduldhall
Copy link
Contributor

Fixed fr_CA time format strings by correctly escaping 'h'.

Thanks Chris Anderson for the report.

Trac ticket number

ticket-36543

Branch description

Escaped the h character in time format strings of fr_CA using \ in order to prevent it being read as the flag for hours.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

nessita
nessita reviewed Aug 8, 2025
View reviewed changes
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @mriduldhall for working on this! 🌟

Could you please add some regression tests in tests/i18n/tests.py?

@mriduldhall
Copy link
Contributor Author

Thank you for the review!! I will add the tests and update the PR.

Apologies for missing them the first time around.

Fixed #36543 -- French Canadian locale formats times incorrectly.
0b92f43 
Fixed fr_CA time format strings by correctly escaping 'h'. Added tests
for fr_CA locale.

Thanks Chris Anderson for the report.
@mriduldhall
Copy link
Contributor Author

I have added the tests. I would be happy to make further improvements based on any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nessita nessita nessita left review comments

@Maibrahim30 Maibrahim30 Maibrahim30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mriduldhall @nessita @Maibrahim30