Remove tox #2135
Remove tox #2135
Conversation
| matrix: | ||
| # tox-gh-actions will only run the tox environments which match the currently | ||
| # running python-version. See [gh-actions] in tox.ini for the mapping. | ||
| python-version: ["3.12"] |
There was a problem hiding this comment.
My preference would be to leave the matrix strategy in place, remove the comment about tox-gh-actions, and add a comment to say that new Python versions can be added here when upgrading to support both side by side.
There was a problem hiding this comment.
Hey @tobiasmcnulty , this was discussed in #1890 (comment) . Because we don't need to support multiple versions at the same deployment, Python version updates and their testing / QA processes can be handled in their own branches. I see no harm in keeping the matrix but I also don't see the benefit.
There was a problem hiding this comment.
Btw, because of Trac, I don't think we will be able to update the Python version any time soon. This was one of the major points for discussions about moving away from Trac.
There was a problem hiding this comment.
Hi @ulgens, if I recall, upgrading the website separately from Trac is the benefit of the matrix strategy.
I'm not very familiar with the dependencies between the two repos, but perhaps we should add python3.11 to the matrix now, since that's what Trac is using? Maybe you have some insight on this @bmispelon?
When I added 3.12 support for the website, a few requirements had to remained pinned to the older versions I believe so as not to break the Trac integration.
.github/workflows/tests.yml
Outdated
| @@ -38,7 +32,8 @@ jobs: | |||
| python-version: "${{ matrix.python-version }}" | |||
There was a problem hiding this comment.
Isn't that going to be broken now that you've removed the version matrix?
There was a problem hiding this comment.
The
python-versioninput is not set. The version of Python currently inPATHwill be used.
It seems Github was automatically picking up Python 3.12.3 and doesn't fail, and I missed that.
I pushed a fix to specify 3.12 explicitly.
There was a problem hiding this comment.
I've read through the comments and I think we're all mostly in agreement: tox can go.
Regarding the version matrix, I think it can be safely removed now that:
- Both the websiste and Trac are dockerized (they can run independent python versions as long as they run django versions that are database-compatible)
- We will switch to a preview server (see #1922 and #2153)
There are still mentions of the version matrix in the yaml file though, I think those should be removed. Come to think of it, what will be the new single source of truth when it comes to the Python version if we remove the matrix?
Resolves django#1817 Resolves django#1890
e38e7ba to
f2293d6
Compare
You are right, I pushed an update.
For the test pipeline, we can continue to use the same |
Resolves:
Depends on: