Skip to content

W003 check fails with OrderedModelQuerySet as_manager. #333

@Eraldo

Description

@Eraldo

I am using a custom queryset that inherits from OrderedModelQuerySet.
Later I call .as_manager to create the default objects manager.

With this setup I still get the W003 warning even though I am subclassing from OrderedModelQuerySet.

code example...

class ValueQuerySet(OrderedModelQuerySet, OwnedQuerySet):
    def search(self, query):
        return self.filter(
            Q(name__icontains=query) | Q(definition__icontains=query),
        )
    ...
    
class Value(TimeStampedBase, OrderedModel):
    name = models.CharField(
        verbose_name=_("name"),
        max_length=255,
    )
    ...

    objects = ValueQuerySet.as_manager()

    class Meta(OrderedModel.Meta):
        unique_together = ["owner", "name"]
        ...

Check warning...

django  | Value: (ordered_model.W003) OrderedModelBase subclass has a ModelManager that does not inherit from OrderedModelManager. This is not ideal but will work.

I get that I could create yet another class for the manager and use that instead, but wouldn't it make sense that calling "as_manager" on the OrderedModelQuerySet would also work? To me it does. ;)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions