Skip to content

fix: enhance focus handling #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: enhance focus handling #2595

wants to merge 2 commits into from

Conversation

sy-records
Copy link
Member

Summary

Related issue, if any:

Fix #2594
Fix #2569

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel Vercel
Copy link

vercel bot commented Aug 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 4:55am

@paulhibbitts paulhibbitts self-requested a review August 8, 2025 13:39
paulhibbitts
paulhibbitts approved these changes Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@paulhibbitts paulhibbitts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @sy-records , from a UX perspective this looks fantastic!

I've run some additional tests, here is the initial code sandbox now using your PR build:
https://codesandbox.io/p/sandbox/docsify-v5-rc-1-coverpage-jx2rl3

The coverpage title link now scrolls to the expected location. To help ensure this PR did not introduce other side-effects, I also updated the earlier HTML Anchor test with your PR build and all looks good there too:
https://paulhibbitts.github.io/docsify-v5-anchors-test/#/anchors-test

And finally I updated the earlier GitHub Pages test with your PR build and all looks good there as well:
https://paulhibbitts.github.io/docsify-v5-preview-coverpage/

The next RC is looking to be really really good 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhibbitts paulhibbitts paulhibbitts approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of Coverpage H1 (Title) as link to start of content not working as expected in v5 Preview
2 participants
@sy-records @paulhibbitts