-
Notifications
You must be signed in to change notification settings - Fork 16.3k
feat: context bridge support VideoFrame #47316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I also have a feature request about VideoFrame which has been supported called copy-video-frame when right click the context menu on a video player in chrome. However, I don`t know how to start. |
How efficient is video frame serialization? I previously experimented with transmitting the ArrayBuffer between the front-end and back-end, but the performance was very poor. |
9882369
to
79faf4a
Compare
79faf4a
to
5467352
Compare
It has nothing to do with serialization |
5467352
to
10daa77
Compare
@codebytere @MarshallOfSound @VerteDinde Hi guys! Sorry for ping, but this and #47317 are ready for review! Could you spare some time review these two parts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Ah 💩, here we go again. |
b4e8d6a
to
c181aab
Compare
@erickzhao Hey Erick, could you rerun flaky checks or just directly merge this? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
No Release Notes |
Description of Change
Add
VideoFrame
support for contextBridge. Split from #46811Release Notes
Notes: none