Skip to content

feat: context bridge support VideoFrame #47316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025

Conversation

reitowo
Copy link
Member

@reitowo reitowo commented May 30, 2025

Description of Change

Add VideoFrame support for contextBridge. Split from #46811

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 30, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 6, 2025
@velentZ
Copy link

velentZ commented Jun 17, 2025

I also have a feature request about VideoFrame which has been supported called copy-video-frame when right click the context menu on a video player in chrome. However, I don`t know how to start.
Please give me a guidence, thanks

@josefhernandez
Copy link

How efficient is video frame serialization? I previously experimented with transmitting the ArrayBuffer between the front-end and back-end, but the performance was very poor.

@reitowo reitowo force-pushed the main-video-frame-bridge branch from 9882369 to 79faf4a Compare July 6, 2025 16:21
@reitowo reitowo marked this pull request as ready for review July 6, 2025 16:21
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 6, 2025
@reitowo reitowo force-pushed the main-video-frame-bridge branch from 79faf4a to 5467352 Compare July 6, 2025 17:53
@reitowo
Copy link
Member Author

reitowo commented Jul 9, 2025

It has nothing to do with serialization

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 13, 2025
@reitowo reitowo force-pushed the main-video-frame-bridge branch from 5467352 to 10daa77 Compare July 14, 2025 14:29
@reitowo
Copy link
Member Author

reitowo commented Jul 21, 2025

@codebytere @MarshallOfSound @VerteDinde Hi guys! Sorry for ping, but this and #47317 are ready for review! Could you spare some time review these two parts?

@erickzhao erickzhao added the semver/minor backwards-compatible functionality label Jul 24, 2025
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@reitowo
Copy link
Member Author

reitowo commented Jul 31, 2025

Ah 💩, here we go again.

@reitowo reitowo force-pushed the main-video-frame-bridge branch from b4e8d6a to c181aab Compare July 31, 2025 19:29
@reitowo
Copy link
Member Author

reitowo commented Aug 5, 2025

@erickzhao Hey Erick, could you rerun flaky checks or just directly merge this? Thank you!

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Member

@itsananderson itsananderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc jkleinsc merged commit 095e622 into electron:main Aug 7, 2025
149 of 152 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 7, 2025

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants