Skip to content

feat: add {get|set}AccentColor on Windows #47741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 1, 2025
Merged

feat: add {get|set}AccentColor on Windows #47741

merged 6 commits into from
Aug 1, 2025

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jul 14, 2025 •
edited
Loading

Description of Change

Closes #47584.

Adds the ability to change window accent color on Windows after initial window initialization.

cc @bpasero

Demo

https://gist.github.com/237ddda00daa4fe47fe7b11a4abd9f61

rainbow

Checklist

Release Notes

Notes: Adds the ability to change window accent color on Windows after initial window initialization via {get|set}AccentColor.

@codebytere codebytere requested review from deepak1556, mlaurencin and a team July 14, 2025 08:39
@codebytere codebytere added semver/minor backwards-compatible functionality target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 14, 2025
@bpasero
Copy link
Contributor

bpasero commented Jul 14, 2025

@codebytere nice, just to clarify: this method - when called - changes the option only for the window its called on, it will not impact other windows? So essentially each window can have its own behaviour around accentColor?

@codebytere
Copy link
Member Author

@bpasero yes, correct!

@codebytere codebytere force-pushed the fix-accent-color-for-changes branch 3 times, most recently from 41e722c to 9daba33 Compare July 14, 2025 11:13
deepak1556
deepak1556 reviewed Jul 14, 2025
View reviewed changes
@codebytere codebytere force-pushed the fix-accent-color-for-changes branch from 9daba33 to 767e34c Compare July 14, 2025 14:02
@codebytere codebytere marked this pull request as draft July 14, 2025 16:52
@codebytere codebytere force-pushed the fix-accent-color-for-changes branch from 0cc62a7 to 9ab68b0 Compare July 14, 2025 18:48
@codebytere codebytere requested a review from deepak1556 July 15, 2025 07:46
@codebytere codebytere marked this pull request as ready for review July 15, 2025 07:47
deepak1556
deepak1556 reviewed Jul 15, 2025
View reviewed changes
deepak1556
deepak1556 reviewed Jul 15, 2025
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

@codebytere codebytere force-pushed the fix-accent-color-for-changes branch from 9ab68b0 to d093701 Compare July 15, 2025 13:28
itsananderson
itsananderson reviewed Jul 15, 2025
View reviewed changes
Copy link
Member

@itsananderson itsananderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it'd be better to have getAccentColor reflect what was passed to setAccentColor, rather than trying to insert the system color if accent_color_ is true. It feels weird for getAccentColor to return less granular information than what was passed into setAccentColor 🤔

docs/api/browser-window.md

Sets the system accent color and highlighting of active window border.

#### `win.getAccentColor()` _Windows_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like with this API, it won't be possible to distinguish between a window which has its accent color pinned to the system accent color (e.g. via setAccentColor(true)) and a window that happens to have the same color as the system accent color (e.g. via setAccentColor(systemPreferences.getAccentColor())).

Do we want to have a way to explicitly check if a window's accent color follows the System Settings?

Copy link
Member Author

@codebytere codebytere Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsananderson we discussed this in API and the way we understood it after discussion is that the window has or doesn't have accent color regardless if whether one was set by the user. E.g. like win.getBounds() - a window has bounds regardless of whether they were set via win.setBounds.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 22, 2025
@codebytere codebytere force-pushed the fix-accent-color-for-changes branch from d093701 to bedd478 Compare July 23, 2025 09:08
@codebytere codebytere requested a review from samuelmaddock July 23, 2025 09:13
@codebytere @itsananderson
Update docs/api/base-window.md
25d1da8 
Co-authored-by: Will Anderson <andersonw@dropbox.com>
@codebytere codebytere force-pushed the fix-accent-color-for-changes branch from 5f9e212 to 25d1da8 Compare July 31, 2025 09:11
@codebytere codebytere merged commit 5c98e36 into main Aug 1, 2025
143 of 149 checks passed
@codebytere codebytere deleted the fix-accent-color-for-changes branch August 1, 2025 20:29
@release-clerk
Copy link

release-clerk bot commented Aug 1, 2025

Release Notes Persisted

Adds the ability to change window accent color on Windows after initial window initialization via {get|set}AccentColor.

@trop
Copy link
Contributor

trop bot commented Aug 1, 2025

I was unable to backport this PR to "37-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/37-x-y PR should also be added to the "37-x-y" branch. label Aug 1, 2025
@trop
Copy link
Contributor

trop bot commented Aug 1, 2025

I was unable to backport this PR to "36-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/37-x-y needs-manual-bp/36-x-y and removed target/36-x-y PR should also be added to the "36-x-y" branch. labels Aug 1, 2025
@trop trop bot mentioned this pull request Aug 1, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Aug 1, 2025

I have automatically backported this PR to "38-x-y", please check out #47939

@trop trop bot added in-flight/38-x-y merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/38-x-y labels Aug 1, 2025
@codebytere
Copy link
Member Author

/trop run backport-to 37-x-y,36-x-y

@trop
Copy link
Contributor

trop bot commented Aug 9, 2025

The backport process for this PR has been manually initiated - sending your PR to 37-x-y!

@trop
Copy link
Contributor

trop bot commented Aug 9, 2025

The backport process for this PR has been manually initiated - sending your PR to 36-x-y!

This was referenced Aug 9, 2025
Open
Merged
@trop
Copy link
Contributor

trop bot commented Aug 9, 2025

I have automatically backported this PR to "37-x-y", please check out #48017

@trop trop bot added the in-flight/37-x-y label Aug 9, 2025
@trop
Copy link
Contributor

trop bot commented Aug 9, 2025

I have automatically backported this PR to "36-x-y", please check out #48018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsananderson itsananderson itsananderson left review comments

@deepak1556 deepak1556 deepak1556 approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@mlaurencin mlaurencin Awaiting requested review from mlaurencin

Assignees
No one assigned
Labels
api-review/approved ✅ in-flight/37-x-y merged/36-x-y PR was merged to the "36-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to update accentColor for an existing window
5 participants
@codebytere @bpasero @itsananderson @deepak1556 @samuelmaddock