fix: launch crash when null device is disabled on Windows #47870
+68
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@zuohuiyang could you please rebase this? You'll also need to sign your commit before it can be merged. |
ce779e3 to
ec5de79
Compare
add node flag node::ProcessInitializationFlags::kNoStdioInitialization Co-authored-by: yangliu <yangliu.leo@bytedance.com>
ec5de79 to
d5ef01b
Compare
|
@codebytere Okay, I've rebased and signed my commit. |
codebytere
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add node flag node::ProcessInitializationFlags::kNoStdioInitialization
Description of Change
This PR continues #44882 (originally by @yangllu, my colleague).
I've taken over this task and addressed all 4 review comments:
All 3 were updated exactly as suggested (@deepak1556).
For parameter passing, I didn’t just send it to the Renderer. Since the node module is also used in the Utility process, I added it there as well."
Checklist
npm testpassesRelease Notes
Notes: add support for
--no-stdio-initto be used when nul device is disabled on windows