Skip to content

test: support for multimonitor tests #47911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: gsoc-2025
Choose a base branch
from
Open

test: support for multimonitor tests #47911

wants to merge 6 commits into from
+738 −1

Conversation

nilayarya
Copy link
Contributor

@nilayarya nilayarya commented Jul 30, 2025 •
edited
Loading

Description of Change

Note

This PR is part of GSoC 2025 [project] [rfc]

Description of Change

This PR adds a new native addon fixture for testing virtual display functionality in Electron. The virtual-display addon provides programmatic virtual display creation capabilities on macOS for comprehensive display testing scenarios.

Example usage:

const virtualDisplay = require('@electron-ci/virtual-display');
const displayId = virtualDisplay.create();
virtualDisplay.destroy(displayId);

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 30, 2025
@dsanders11 dsanders11 added GSoC 2025 Google Summer of Code 2025 semver/none no-backport backport-check-skip Skip trop's backport validity checking labels Jul 30, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 30, 2025
github-actions[bot]
github-actions bot previously requested changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nilayarya! It looks like this pull request touches one of our dependency files, and per our contribution policy we do not accept these types of changes in PRs.

@nilayarya nilayarya marked this pull request as draft August 1, 2025 14:32
@nilayarya nilayarya marked this pull request as ready for review August 3, 2025 15:14
@codebytere codebytere dismissed github-actions[bot]’s stale review August 4, 2025 08:35

Permitted in this case.

georgexu99
georgexu99 reviewed Aug 5, 2025
View reviewed changes
Copy link
Contributor

@georgexu99 georgexu99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs: approved

erickzhao
erickzhao reviewed Aug 5, 2025
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a test: prefix PR and be stacked on top of #47781, right?

@nilayarya
Copy link
Contributor Author

I think this should be a test: prefix PR and be stacked on top of #47781, right?

Since this is a new independent API to create virtual displays wouldn’t it make more sense to label it as feat:?
I might have branched off incorrectly sorry for that.

@codebytere codebytere changed the title feat: support for multimonitor tests test: support for multimonitor tests Aug 6, 2025
@nilayarya nilayarya force-pushed the multi-display-test branch from 81beead to 94463ad Compare August 7, 2025 16:38
VerteDinde
VerteDinde approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao left review comments

@georgexu99 georgexu99 georgexu99 left review comments

@VerteDinde VerteDinde VerteDinde approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
backport-check-skip Skip trop's backport validity checking GSoC 2025 Google Summer of Code 2025 no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nilayarya @VerteDinde @erickzhao @georgexu99 @dsanders11