Skip to content

refactor: avoid deprecated v8::Context::GetIsolate() pt 4 #47961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 6, 2025

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Aug 4, 2025

Description of Change

Fourth and final PR in a series of PRs to reduce use of v8::Context::GetIsolate() since that method has been deprecated upstream.

This PR removes most of the instances used by the context bridge and its callers.

Checklist

Release Notes

Notes: none.

@ckerr ckerr added semver/patch backwards-compatible bug fixes target/38-x-y PR should also be added to the "38-x-y" branch. labels Aug 4, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 4, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 6, 2025
@ckerr ckerr merged commit 7a13c6f into main Aug 6, 2025
152 of 157 checks passed
@ckerr ckerr deleted the refactor/avoid-deprecated-v8-Context-GetIsolate-pt-4 branch August 6, 2025 01:08
@release-clerk
Copy link

release-clerk bot commented Aug 6, 2025

No Release Notes

@trop
Copy link
Contributor

trop bot commented Aug 6, 2025

I have automatically backported this PR to "38-x-y", please check out #47973

@trop trop bot added in-flight/38-x-y merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/38-x-y labels Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants