Skip to content

fix: restore window's canHide property on macOS #47970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: restore window's canHide property on macOS #47970

wants to merge 1 commit into from
+3 −0

Conversation

cucbin
Copy link
Contributor

@cucbin cucbin commented Aug 5, 2025 •
edited
Loading

Description of Change

If calling app.dock?.hide() and hiding the window, even if the window is restored, window can no longer be hided.
It due to API set canHide property while calling app.dock?.hide()

electron/shell/browser/browser_mac.mm

Lines 531 to 532 in 678fb40

for (auto* const& window : WindowList::GetWindows())
[window->GetNativeWindow().GetNativeNSWindow() setCanHide:NO];

Checklist

Release Notes

Notes: Restored window's canHide property

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 5, 2025
@codebytere codebytere self-requested a review August 6, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere Awaiting requested review from codebytere

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
new-pr 🌱 PR opened recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cucbin