bugfix: native module resolution is broken #3680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the official 'package.json' docs regarding "main" property make it seems like the recently introduced 'electronmon .' approach could work, it turns out that's not the case. When going via 'main' property, regardless of the specified path, the actual "nodejs module resolution" will start at the '<repo>/node_modules/' level and then bubble upwards. As a result the symlinked folders '<repo>/src/node_modules' and '<repo/.erb/node_modules/' will not be considered, hence native module resolution breaks. The solution is simply to specify the 'main.bundle.dev.js' file directly in regards to the 'electronmon' call. Furthermore the 'main' property was removed altogether now, cause it seemingly serves no practical purpose in this template and at best is misleading if it were to stay around.
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the official 'package.json' docs regarding "main" property make it seems like the recently introduced 'electronmon .' approach could work, it turns out that's not the case.
When going via 'main' property, regardless of the specified path, the actual "nodejs module resolution" will start at the '/node_modules/' level and then bubble upwards. As a result the symlinked folders '/src/node_modules' and '<repo/.erb/node_modules/' will not be considered, hence native module resolution breaks.
The solution is simply to specify the 'main.bundle.dev.js' file directly in regards to the 'electronmon' call.
Furthermore the 'main' property was removed altogether now, cause it seemingly serves no practical purpose in this template and at best is misleading if it were to stay around.