test: fix failing coverage adding tests on closeAllConnections #6083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf95331 to
f7536c2
Compare
|
Still need to understand why the test fails on node 20 and not on node 22. |
21cdd7f to
bb4fe88
Compare
bb4fe88 to
327e9a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that the coverage threshold is not currently satisfied locally, since lines 172-173 in
lib/server.jsare not covered.In #6069 this was preventing my commit since the pre-commit hook was failing locally. On CI pipeline it should not be a problem, it seems to work and the coverage is at 100%.
I added the tests to fix the issue.
Mocking
dns.lookupis needed in order to ensure that the secondary server always gets created whenhostis set tolocalhost. Even when thealloptions is set totruethe OS can choose to return only the IPv4 address, resulting in the missing creation of the secondary server.Checklist
npm run testandnpm run benchmarkand the Code of conduct