Skip to content

fix(types): correct generic defaults in setErrorHandler to fix TS2744… #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(types): correct generic defaults in setErrorHandler to fix TS2744… #6140

wants to merge 1 commit into from

Conversation

sakshyasinha
Copy link

  • Changed generic parameter defaults in setErrorHandler to reference previously declared types.
  • Updated indentation and formatting to match ESLint stylistic rules.
  • This fixes TypeScript errors related to type parameter defaults referencing themselves.

Checklist

@sakshyasinha
fix(types): correct generic defaults in setErrorHandler to fix TS2744…
1801278 
… errors

- Changed generic parameter defaults in setErrorHandler to reference previously declared types.
- Updated indentation and formatting to match ESLint stylistic rules.
- This fixes TypeScript errors related to type parameter defaults referencing themselves.
@github-actions github-actions bot added the typescript TypeScript related label May 26, 2025
mcollina
mcollina requested changes May 26, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? We use tsd for the types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
typescript TypeScript related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakshyasinha @mcollina