ref(grouping): remove line and column numbers from similar issues stacktrace diff #97536
+61
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
scttcper
reviewed
Aug 8, 2025
| @@ -79,7 +84,7 @@ function getPythonFrame(frame: Frame): string { | |||
| return result; | |||
| } | |||
|
|
|||
| export function getJavaFrame(frame: Frame): string { | |||
| export function getJavaFrame(frame: Frame, includeLocation = true): string { | |||
There was a problem hiding this comment.
this function is only called in this file and in tests, lets make includeLocation a required parameter and update the tests. I'd do the same with the other functions.
Adding a test in static/app/components/events/interfaces/crashContent/stackTrace/rawContent.spec.tsx for this might also be good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line and column numbers aren't considered in grouping so there is no need to highlight them in the stacktrace diff for similar issues.
Added an
includeLocationoption to thegetFramefunctions to turn off getting line/column numbers.Before:
After:
