feat(crons): Start dual writing DataSource and Detector rows for crons
#97542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
commented
Aug 8, 2025
| @@ -383,3 +389,24 @@ def update_issue_alert_rule( | |||
| ) | |||
|
|
|||
| return issue_alert_rule.id | |||
|
|
|||
|
|
|||
| def ensure_cron_detector(monitor: Monitor): | |||
There was a problem hiding this comment.
I don't feel like much can go wrong here, but if we want to be more cautious we could put this creation behind a flag.
1c4782e to
a37d0c5
Compare
…crons We want to have these rows available so that we can start linking crons to workflows.
a37d0c5 to
aada4a3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## danf/crons-data-source-handler #97542 +/- ##
===============================================================
Coverage 80.62% 80.62%
===============================================================
Files 8560 8560
Lines 376917 376933 +16
Branches 24538 24538
===============================================================
+ Hits 303889 303916 +27
+ Misses 72658 72647 -11
Partials 370 370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to have these rows available so that we can start linking crons to workflows.