Add logs table row buttons (filters, copy as json etc.) #97545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some actions below the details when opening a log in the logs table.
| </Button> | ||
| </LogDetailTableActionsButtonBar> | ||
| </LogDetailTableActionsCell> | ||
| )} |
There was a problem hiding this comment.
Bug: Table Rendering Issues and Button Crashes
The expanded log row (DetailsWrapper, a <tr>) incorrectly renders two <td> cells (LogDetailTableBodyCell and LogDetailTableActionsCell), each set to span all columns. This invalid table structure can cause unpredictable rendering and layout issues.
Additionally, clicking the "View Trace" button crashes for logs without a trace_id because adjustLogTraceID is called with an undefined value, leading to a TypeError when .replace() is invoked. The button should be hidden/disabled or the call guarded.
Finally, the LogDetailTableActionsCell is missing display: "flex", preventing its alignItems, justifyContent, and flexDirection styles from applying, which can lead to incorrect button layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds some actions below the details when opening a log in the logs table.