Skip to content

fix(export): show 'Data export requires Business Plan' on 404 for SaaS #97546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+75 −32
Open

fix(export): show 'Data export requires Business Plan' on 404 for SaaS #97546

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfe9e2e
dataExport: show 'Data export requires Business Plan' on 404 for SaaS…
JoshFerge Aug 8, 2025
240d5d9
dataExport: gate export button with Feature and disable on missing di…
JoshFerge Aug 8, 2025
43aa5a2
dataExport: revert to not rendering anything for unauthorized orgs (n…
JoshFerge Aug 8, 2025
fd2b236
fix
JoshFerge Aug 8, 2025
01c0c79
tagExportDropdown: hide when org lacks organizations:discover-query; …
JoshFerge Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dataExport: gate export button with Feature and disable on missing di… 
…scover-query; show GS hovercard via hookName
  • Loading branch information
@JoshFerge
JoshFerge committed Aug 8, 2025
commit 240d5d9b0d46d0afa2d7de1f03d51e9607717585
62 changes: 35 additions & 27 deletions static/app/components/dataExport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,33 +128,41 @@ function DataExport({
}, []);

return (
<Feature features="organizations:discover-query">
{inProgress ? (
<Button
size="sm"
priority="default"
title={t(
"You can get on with your life. We'll email you when your data's ready."
)}
disabled
icon={icon}
>
{t("We're working on it...")}
</Button>
) : (
<Button
onClick={debounce(handleDataExport, 500)}
disabled={disabled || false}
size="sm"
priority="default"
title={t(
"Put your data to work. Start your export and we'll email you when it's finished."
)}
icon={icon}
>
{children ? children : t('Export All to CSV')}
</Button>
)}
<Feature
features="organizations:discover-query"
hookName="feature-disabled:grid-editable-actions"
renderDisabled={props =>
typeof props.children === 'function' ? props.children(props) : props.children
}
>
{({hasFeature}) =>
inProgress ? (
<Button
size="sm"
priority="default"
title={t(
"You can get on with your life. We'll email you when your data's ready."
)}
disabled
icon={icon}
>
{t("We're working on it...")}
</Button>
) : (
<Button
onClick={debounce(handleDataExport, 500)}
disabled={Boolean(disabled) || !hasFeature}
size="sm"
priority="default"
title={t(
"Put your data to work. Start your export and we'll email you when it's finished."
)}
icon={icon}
>
{children ? children : t('Export All to CSV')}
</Button>
)
}
</Feature>
);
}
Expand Down
Loading