C++: Fix FP in cpp/overflow-buffer
#20193
Merged
+45
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a false positive in the cpp/overflow-buffer query by properly handling reference types. The issue was that reference types were excluded from size calculations in one part of the getSize predicate but not in another, causing false positives when capturing destination variables by reference in lambdas.
- Extracts reference type handling into a shared helper predicate
getVariableSize - Updates both disjuncts of
getSizeto consistently exclude reference types from size calculations - Adds a test case demonstrating the fixed scenario with lambda capture by reference
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Buffer.qll | Adds getVariableSize helper and updates getSize to consistently exclude reference types |
| tests.cpp | Adds test case test31 demonstrating lambda capture scenario that should not trigger false positive |
| UnboundedWrite.expected | Updates expected test results with corrected line numbers after adding new test case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We "handled" reference types in one disjunct of
getSize, but not in the other (where by "handle" I mean "excluded"). This caused some FPs when capturing the destination variable by reference in a lambda.This PR fixes that by properly excluding reference types as sources in both disjuncts.
Commit-by-commit review recommended.
DCA looks uneventful.