Skip to content

add try-with-resources around json parsing in controllers #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

add try-with-resources around json parsing in controllers #19

merged 2 commits into from
Jul 28, 2025

Conversation

countableSet
Copy link

  • add a try-with-resources around InputStreamReader reader = new InputStreamReader(request.getInputStream(), StandardCharsets.UTF_8) since the json parser doesn't close the reader
  • bump gradle to latest
  • use new shadrow plugin

cc @github/data-pipelines
cc https://github.com/github/pipeline-monitor/security/code-scanning/827

@countableSet countableSet requested review from a team and Copilot July 28, 2025 19:24
Copilot

This comment was marked as spam.

Sign in to view

@countableSet countableSet merged commit b64feb4 into master Jul 28, 2025
1 check passed
@countableSet countableSet deleted the close-reader branch July 28, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jlisam jlisam jlisam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@countableSet @jlisam