Skip to content

Fix font-size in inline code comment preview #35209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2025
+2 −13
Merged

Fix font-size in inline code comment preview #35209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dea058c
Fix font-size in inline comment preview
silverwind Aug 4, 2025
9f732d9
use default 14px and override it for file-view
silverwind Aug 4, 2025
07849ab
Update web_src/css/markup/content.css
silverwind Aug 4, 2025
13726a6
Update web_src/css/markup/content.css
silverwind Aug 4, 2025
49db087
Merge branch 'main' into markupfont
lafriks Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use default 14px and override it for file-view
  • Loading branch information
@silverwind
silverwind committed Aug 4, 2025
commit 9f732d9ac603cf7adf93b2297f99885a0d9d2fd4
3 changes: 2 additions & 1 deletion web_src/css/markup/content.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.markup {
overflow: hidden;
font-size: 16px;
font-size: 14px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove this and use the parent's font-size.

Body's default font-size is also 14px IIRC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have html, body {font-size: 14px}, yes. But I'm not confident that inheriting wouldn't break anything. I think it's better to explicitely specify 14px/16px than to rely on potentially incorrect surrounding content.

line-height: 1.5 !important;
overflow-wrap: break-word;
}
Expand Down Expand Up @@ -318,6 +318,7 @@ In markup content, we always use bottom margin for all elements */

.file-view.markup {
padding: 1em 2em;
font-size: 16px;
}

.file-view.markup:has(.file-not-rendered-prompt) {
Expand Down
7 changes: 0 additions & 7 deletions web_src/css/repo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,13 +300,6 @@ td .commit-summary {
min-width: 100px;
}

.repository.new.issue .comment.form .content .markup,
.repository.compare.pull .markup,
.repository.view.issue .comment-list .comment .markup,
.conversation-holder .markup {
font-size: 14px;
}

.repository.view.issue .instruct-toggle {
display: inline-block;
}
Expand Down