feat: support multi-line selection with URL parameters #35210
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kerwin612
commented
Aug 4, 2025
silverwind
reviewed
Aug 4, 2025
silverwind
reviewed
Aug 4, 2025
Co-authored-by: silverwind <me@silverwind.io> Signed-off-by: Kerwin Bryant <kerwin612@qq.com>
Co-authored-by: silverwind <me@silverwind.io> Signed-off-by: Kerwin Bryant <kerwin612@qq.com>
appleboy
approved these changes
Aug 4, 2025
lunny
approved these changes
Aug 5, 2025
wxiaoguang
requested changes
Aug 5, 2025
wxiaoguang
reviewed
Aug 5, 2025
291c27c to
886f546
Compare
|
Have you fixed the problems? 
ps: I don't have time recently, feel free to ask other maintainers to review and dismiss my "change request" if the bugs have been fixed. |
wxiaoguang
reviewed
Aug 9, 2025
wxiaoguang
reviewed
Aug 11, 2025
| @@ -14,7 +14,7 @@ function changeHash(hash: string) { | |||
| // it selects the code lines defined by range: `L1-L3` (3 lines) or `L2` (singe line) | |||
| function selectRange(range: string): Element { | |||
| for (const el of document.querySelectorAll('.code-view tr.active')) el.classList.remove('active'); | |||
| const elLineNums = document.querySelectorAll(`.code-view td.lines-num span[data-line-number]`); | |||
| const elLineNums = document.querySelectorAll(`.code-view td.lines-num span[id^="L"]`); | |||
There was a problem hiding this comment.
Still don't understand why you need to change the selector.
span[data-line-number] is clearer and literally more correct than span[id^="L"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.