Skip to content

db: migrate org.go to organizations.go with GORM #7538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

db: migrate org.go to organizations.go with GORM #7538

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
10fd9e9
db: migrate `org.go` to `orgs.go` with GORM
unknwon Aug 24, 2023
9cc3cc7
style: format code with Go fmt and Gofumpt
deepsource-autofix[bot] Nov 2, 2023
371c56e
fixup
unknwon Nov 3, 2023
e0a14a5
Use `OrganizationsStore.Create` replace tests hack
unknwon Nov 3, 2023
a449284
Fix `Orgs.Join`
unknwon Nov 4, 2023
ac636b5
`DeleteByID`
unknwon Nov 4, 2023
bd31c3f
Delete `GetOrgsByUserID`
unknwon Nov 4, 2023
b332af5
Fix damn test
unknwon Nov 4, 2023
a18290d
fix race
unknwon Nov 4, 2023
849d281
GetOwnedOrgsByUserIDDesc
unknwon Nov 5, 2023
2971cab
getOrgUsersByOrgID
unknwon Nov 5, 2023
9797508
GetUserMirrorRepositories
unknwon Nov 5, 2023
b49e4a4
fixup
unknwon Nov 5, 2023
ed260cb
orgsCreate
unknwon Nov 5, 2023
26f8ddf
orgsGetByName
unknwon Nov 5, 2023
0ca926e
fixup
unknwon Nov 13, 2023
cbd3c7a
orgsList
unknwon Nov 13, 2023
6345c50
orgsCount
unknwon Nov 13, 2023
bf92bcd
orgsDeleteByID
unknwon Nov 13, 2023
fce3e65
orgsAddMember
unknwon Nov 14, 2023
5ab8262
orgsRemoveMember
unknwon Nov 14, 2023
7d4c5b4
Check access before watch repo
unknwon Nov 16, 2023
b2a0ce6
orgsHasMember
unknwon Nov 16, 2023
54d5e4c
style: format code with Go fmt and Gofumpt
deepsource-autofix[bot] Nov 16, 2023
c5fa4cf
orgsListMembers
unknwon Nov 17, 2023
22526be
orgsIsOwnedBy
unknwon Nov 17, 2023
34e59c2
orgsSetMemberVisibility
unknwon Nov 17, 2023
f0fed90
Add tests
unknwon Nov 26, 2023
403e1fb
Fix test
unknwon Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
orgsList
  • Loading branch information
@unknwon
unknwon committed Dec 17, 2023
commit cbd3c7a40b6e2d28c9e9af0374cff0b9751d3b89
45 changes: 41 additions & 4 deletions internal/db/organizations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ func TestOrganizations(t *testing.T) {
}{
{"Create", orgsCreate},
{"GetByName", orgsGetByName},
{"List", orgsList},
{"SearchByName", orgsSearchByName},
{"List", orgsList},
{"CountByUser", orgsCountByUser},
} {
t.Run(tc.name, func(t *testing.T) {
Expand Down Expand Up @@ -150,15 +150,17 @@ func orgsList(t *testing.T, ctx context.Context, db *organizations) {
tempPictureAvatarUploadPath := filepath.Join(os.TempDir(), "orgsList-tempPictureAvatarUploadPath")
conf.SetMockPicture(t, conf.PictureOpts{AvatarUploadPath: tempPictureAvatarUploadPath})

org1, err := db.Create(ctx, "org1", alice.ID, CreateOrganizationOptions{})
org1, err := db.Create(ctx, "org1-alice-owned", alice.ID, CreateOrganizationOptions{})
require.NoError(t, err)
org2, err := db.Create(ctx, "org2", alice.ID, CreateOrganizationOptions{})

org2, err := db.Create(ctx, "org2-alice-owned", alice.ID, CreateOrganizationOptions{})
require.NoError(t, err)
err = db.SetMemberVisibility(ctx, org2.ID, alice.ID, true)
require.NoError(t, err)
err = db.AddMember(ctx, org2.ID, bob.ID)
require.NoError(t, err)
err = db.SetMemberVisibility(ctx, org2.ID, alice.ID, true)

org3, err := db.Create(ctx, "org3-bob-owned", bob.ID, CreateOrganizationOptions{})
require.NoError(t, err)

tests := []struct {
Expand All @@ -182,6 +184,22 @@ func orgsList(t *testing.T, ctx context.Context, db *organizations) {
},
wantOrgNames: []string{org1.Name, org2.Name},
},
{
name: "only public ownership for a user",
opts: ListOrganizationsOptions{
OwnerID: alice.ID,
IncludePrivateMembers: false,
},
wantOrgNames: []string{org2.Name},
},
{
name: "all ownership for a user",
opts: ListOrganizationsOptions{
OwnerID: alice.ID,
IncludePrivateMembers: true,
},
wantOrgNames: []string{org1.Name, org2.Name},
},
{
name: "no membership for a non-existent user",
opts: ListOrganizationsOptions{
Expand All @@ -203,6 +221,25 @@ func orgsList(t *testing.T, ctx context.Context, db *organizations) {
assert.Equal(t, test.wantOrgNames, gotOrgNames)
})
}

t.Run("pagination", func(t *testing.T) {
got, err := db.List(ctx, ListOrganizationsOptions{Page: 1, PageSize: 1})
require.NoError(t, err)
require.Len(t, got, 1)
assert.Equal(t, org1.ID, got[0].ID)

got, err = db.List(ctx, ListOrganizationsOptions{Page: 2, PageSize: 1})
require.NoError(t, err)
require.Len(t, got, 1)
assert.Equal(t, org2.ID, got[0].ID)

got, err = db.List(ctx, ListOrganizationsOptions{Page: 1, PageSize: 4})
require.NoError(t, err)
require.Len(t, got, 3)
assert.Equal(t, org1.ID, got[0].ID)
assert.Equal(t, org2.ID, got[1].ID)
assert.Equal(t, org3.ID, got[2].ID)
})
}

func orgsSearchByName(t *testing.T, ctx context.Context, db *organizations) {
Expand Down