Skip to content

Modifications to led controller example #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SpiderDerp
Copy link

On newer module versions, MISO and MOSI pins are referred to as DO and DI.

HTTP requests require a content-length header to prevent a 411 error.

The code was originally made to record audio when the button is not pressed, but it was changed to do the opposite.

MISO and MOSI are referred to as DO and DI on the sd card module now.
Copy link

google-cla bot commented Jul 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Jul 2, 2025
@SpiderDerp
Copy link
Author

I signed the CLA after being notified.

@Giom-V Giom-V requested a review from PaulTR July 8, 2025 17:12
@@ -418,7 +419,7 @@ void setup() {
}

void loop() {
if (digitalRead(BUTTON_PIN) == LOW) {
if (digitalRead(BUTTON_PIN) == HIGH) { //check if button is pressed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the diagram there's a pull down resistor with the button - guessing you're using a different setup? This will likely change for people depending on what button they're using.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the diagram with the pull-down resistor and the button, but the recording that is supposed to occur upon button press only worked for me when I modified this line. Otherwise, it would record when the button is not being pressed.
It could be possible that I made a wiring mistake, so feel free to ignore this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:examples Issues/PR referencing examples folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants