fix(issue-634): reduce memory leak #686
Open
+624
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #634
helm <command>
only runs it onceI have tried
deep_copy
https://github.com/helm-unittest/helm-unittest/blob/main/pkg/unittest/deep_copy.go, it does not work very well,Following approach has it's own pros/cons
From the pros side
for idx, testJob := range s.Tests
, we could do them ouside of a loop and pass only files required for current test.cons:
CPU reduction 4 times
Memory reduced in 2.5x times
Before

With the fix

At some point, depends on where or not issue is accepted, I could try to submit few PRs to helm, but the process there is quite lengthy.