Skip to content

improve error messages in SQLQueryParser #10643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025

Conversation

gavinking
Copy link
Member

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [beec635, ba1d17f, 81b3c82, 611f565]

› This message was automatically generated.

aliasesFound++;
return columnAliases[0];
}
}

private void validate(String aliasName, String propertyName, String[] columnAliases) {
private void validate(String aliasName, String propertyName, String[] columnAliases, String token) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'aliasName' is never used.
@gavinking gavinking marked this pull request as ready for review July 29, 2025 23:42
@gavinking gavinking merged commit 38b2d8c into hibernate:main Jul 29, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant