HHH-19015 - Deprecate Session#byId in favor of FindOptions #10671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
380f714 to
855d16a
Compare
sebersole
reviewed
Jul 30, 2025
855d16a to
9605db7
Compare
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
9605db7 to
7623f30
Compare
sebersole
approved these changes
Jul 30, 2025
|
Does it make sense to deprecate the method without also deprecating |
|
Well, at least initially it makes the most sense (simplicity) to simply keep using that infrastructure internally. So for now, I'd say no. After I get the |
|
Well, actually... the interface, yeah I think that does make sense |
|
@DavideD According to the note on IdentifierLoadAccessImpl, Reactive extends all of this so this deprecation will affect you I think. |
|
Thanks, I've seen it. I don't remember exactly how we use it, but it should be fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19015