HHH-14082 Hibernate cannot determine it's core version in modular configuration #10726
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
reviewed
Aug 10, 2025
Comment on lines
-24
to
+26
| final String version = Version.class.getPackage().getImplementationVersion(); | ||
| return version != null ? version : "[WORKING]"; | ||
| ModuleDescriptor moduleDescriptor = Version.class.getModule().getDescriptor() ; | ||
| return moduleDescriptor != null ? (moduleDescriptor.version().isPresent() ? moduleDescriptor.version().toString() : "[WORKING]") : "[WORKING]"; |
There was a problem hiding this comment.
Should there be a fallback to getPackage().getImplementationVersion() somewhere here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHH-14082 Hibernate cannot determine it's core version in modular configuration
Currently the Version gets the information via: Version.class.getPackage().getImplementationVersion()
But in modular mode it should call this instead: Version.class.getModule().getDescriptor().version()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-14082