Skip to content

Upgrade Hibernate ORM to 7.1.0.CR2 #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Conversation

dreab8
Copy link
Member

@dreab8 dreab8 commented Aug 5, 2025

Fix #2404

@dreab8 dreab8 force-pushed the orm_7.1.0.CR2_2 branch 2 times, most recently from 0b453c2 to 16bed3c Compare August 6, 2025 08:32
Copy link
Member

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a first pass.
It seems fine overall, but I left some comments around to discuss.

return null;
}
}
).thenApply( generatedValues -> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use .thenAccept here, and remove the return value

@dreab8 dreab8 force-pushed the orm_7.1.0.CR2_2 branch 2 times, most recently from b72c29b to e35e744 Compare August 6, 2025 13:28
@dreab8 dreab8 changed the base branch from wip/3.1 to 3.1 August 6, 2025 13:41
@DavideD DavideD merged commit 6421104 into hibernate:3.1 Aug 6, 2025
17 checks passed
@DavideD DavideD linked an issue Aug 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Hibernate ORM to 7.1.0.CR2
2 participants