Skip to content

Add Tuya snapshots tests for button and vacuum platform #149968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2025
Merged

Add Tuya snapshots tests for button and vacuum platform #149968

merged 3 commits into from
Aug 5, 2025

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Aug 4, 2025 •
edited
Loading

Proposed change

SSIA, from #141278 and #144362

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 4, 2025

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet marked this pull request as ready for review August 4, 2025 13:04
@Copilot Copilot AI review requested due to automatic review settings August 4, 2025 13:04
Copilot
Copilot AI reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive snapshot tests for the Tuya vacuum platform, addressing issues #141278 and #144362. The tests verify platform setup, device discovery, and the return-to-base functionality.

Key Changes:

  • Adds vacuum platform snapshot tests for device discovery and state validation
  • Includes specific test for return-to-base service functionality
  • Adds test fixture for vacuum device with comprehensive device capabilities

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/components/tuya/test_vacuum.py New test file with snapshot tests for vacuum platform setup, discovery, and return-to-base service
tests/components/tuya/snapshots/test_vacuum.ambr Snapshot file containing expected entity registry and state data for vacuum device
tests/components/tuya/fixtures/sd_lr33znaodtyarrrz.json Test fixture defining a Tuya vacuum device with complete function and status definitions
tests/components/tuya/init.py Updates DEVICE_MOCKS to include the vacuum device for platform testing

@epenet epenet changed the title Add Tuya snapshots tests for vacuum platform Add Tuya snapshots tests for button and vacuum platform Aug 4, 2025
@epenet epenet marked this pull request as draft August 4, 2025 20:32
@epenet epenet force-pushed the epenet-20250804-1456 branch from d2983c5 to d8d8c33 Compare August 5, 2025 08:31
@epenet epenet marked this pull request as ready for review August 5, 2025 08:31
@joostlek joostlek merged commit a6148b5 into dev Aug 5, 2025
34 checks passed
@joostlek joostlek deleted the epenet-20250804-1456 branch August 5, 2025 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality has-tests integration: tuya Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tuya - Vacuum return to home Server Error
2 participants
@epenet @joostlek