Skip to content

Add Tuya snapshots tests for cwysj category (pet water fountain) #150121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2025

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Aug 6, 2025

Proposed change

Based on https://github.com/orgs/home-assistant/discussions/539

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Copilot Copilot AI review requested due to automatic review settings August 6, 2025 14:03
@home-assistant
Copy link

home-assistant bot commented Aug 6, 2025

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds snapshot tests for the Tuya "cwysj" category (pet water fountain) by adding test fixtures and expected output snapshots for a new device model.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/components/tuya/fixtures/cwysj_akln8rb04cav403q.json New test fixture defining a pet water fountain device with switch and sensor capabilities
tests/components/tuya/snapshots/test_switch.ambr Added snapshot expectations for three switch entities (power, filter reset, water pump reset)
tests/components/tuya/snapshots/test_sensor.ambr Added snapshot expectations for two sensor entities (filter duration, water pump duration)
tests/components/tuya/__init__.py Added test configuration for the new device model and reorganized existing entries

@epenet epenet added smash Indicator this PR is close to finish for merging or closing and removed smash Indicator this PR is close to finish for merging or closing labels Aug 7, 2025
@epenet epenet marked this pull request as draft August 7, 2025 13:28
@epenet epenet force-pushed the epenet-20250806-1602 branch from b53c393 to 7515e16 Compare August 10, 2025 14:53
@epenet epenet force-pushed the epenet-20250806-1602 branch from 7515e16 to 12d3129 Compare August 10, 2025 14:54
@epenet epenet marked this pull request as ready for review August 10, 2025 14:54
@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Aug 10, 2025
@joostlek joostlek merged commit 1b7cb41 into dev Aug 10, 2025
30 checks passed
@joostlek joostlek deleted the epenet-20250806-1602 branch August 10, 2025 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality has-tests integration: tuya Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants