Add extract_from_target websocket command #150124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new expand_target websocket command that provides a consistent way for frontend and core to expand various target types (entities, devices, areas, labels) into their constituent entities and references.
- Introduces a new websocket command
expand_targetthat processes target selectors and returns expanded entity references - Adds comprehensive test coverage for the new command including edge cases and validation scenarios
- Provides structured output including referenced entities/devices/areas and missing items for error handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| homeassistant/components/websocket_api/commands.py | Implements the new expand_target websocket command handler with validation and target expansion logic |
| tests/components/websocket_api/test_commands.py | Adds comprehensive test suite covering various target types, edge cases, and validation scenarios |
Comments suppressed due to low confidence (1)
tests/components/websocket_api/test_commands.py:158
- The type annotation
dict[str, str]is incorrect as targets can contain lists of strings, not just strings. Should bedict[str, Any]or a more specific type that accommodates the actual structure.
assert len(runs) == 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a new
expand_targetwebsocket command so that frontend and core have a consistent way of expanding targets.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: