Skip to content

feat: add scaleway inference provider #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add scaleway inference provider #1674

wants to merge 5 commits into from

Conversation

Gnoale
Copy link

@Gnoale Gnoale commented Aug 6, 2025 •
edited
Loading

Hi 🤗
Register Scaleway as inference provider

Test passing

> vitest run --config vitest.config.mts -t Scaleway


 RUN  v0.34.6 /Users/gnoale/git/huggingface.js/packages/inference

stderr | unknown test
Set HF_TOKEN in the env to run the tests for better rate limits

 ↓ src/vendor/fetch-event-source/parse.spec.ts (17) [skipped]
 ✓ test/InferenceClient.spec.ts (112) 6116ms

 Test Files  1 passed | 1 skipped (2)
      Tests  5 passed | 124 skipped (129)
   Start at  14:03:55
   Duration  6.58s (transform 253ms, setup 18ms, collect 327ms, tests 6.12s, environment 0ms, prepare 82ms)

@Gnoale Gnoale force-pushed the feat/scalewayprovider branch 3 times, most recently from 9dc304d to e232732 Compare August 6, 2025 12:11
@Gnoale Gnoale force-pushed the feat/scalewayprovider branch from e232732 to 8d0ba03 Compare August 7, 2025 09:51
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

SBrandeis
SBrandeis approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@SBrandeis SBrandeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean!
I made a few changes to better align with our code style and use the type system a bit more.
Let's wait for a review from @Wauplin or @hanouticelina to move forward but looks good to me!

packages/inference/src/lib/getProviderHelper.ts Outdated
@@ -148,6 +149,12 @@ export const PROVIDERS: Record<InferenceProvider, Partial<Record<InferenceTask,
conversational: new Sambanova.SambanovaConversationalTask(),
"feature-extraction": new Sambanova.SambanovaFeatureExtractionTask(),
},
scaleway: {
conversational: new Scaleway.ScalewayConversationalTask(),
"image-to-text": new Scaleway.ScalewayConversationalTask(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image-text-to-text support is included in conversational handler

Suggested change
"image-to-text": new Scaleway.ScalewayConversationalTask(),

@SBrandeis SBrandeis requested a review from Wauplin August 8, 2025 13:00
hanouticelina
hanouticelina approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! thanks @Gnoale
I tested the PR locally and it works as expected! ✅

Wauplin
Wauplin approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

When we start to integrate and make some comms, let's focus on the chat completion endpoints for now :) (though, good to see the other tasks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

@SBrandeis SBrandeis SBrandeis approved these changes

@hanouticelina hanouticelina hanouticelina approved these changes

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gnoale @HuggingFaceDocBuilderDev @Wauplin @SBrandeis @hanouticelina