Skip to content

Revert FA2 kwargs construction #40029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Revert FA2 kwargs construction #40029

wants to merge 5 commits into from
+69 −31

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

As per title, discussed internally

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

vasqu
vasqu reviewed Aug 8, 2025
View reviewed changes
Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand the PR correctly we're moving back to prepare during generate instead of during the fa forward? 👀

@zucchini-nlp
Copy link
Member Author

So if I understand the PR correctly we're moving back to prepare during generate instead of during the fa forward? 👀

yep, to be explicit + a lil faster than computing in FA2 utils per layer

vasqu
vasqu approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx LGTM, will merge this into #40002 then - hopefully we have a somewhat more clean fa then :D

Failing tests are mostly timeout issues, CI has issues today. Only thing is probably style which is correct failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasqu vasqu vasqu approved these changes

@ArthurZucker ArthurZucker Awaiting requested review from ArthurZucker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zucchini-nlp @HuggingFaceDocBuilderDev @vasqu