Skip to content

[GPT Big Code] Fix attention scaling #40041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 11, 2025
Merged

[GPT Big Code] Fix attention scaling #40041

merged 6 commits into from
Aug 11, 2025
+21 −4

Conversation

vasqu
Copy link
Contributor

@vasqu vasqu commented Aug 8, 2025

Reported internally cc @hmellor @zucchini-nlp

@vasqu vasqu added the for patch Tag issues / labels that should be included in the next patch label Aug 8, 2025
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

ArthurZucker
ArthurZucker approved these changes Aug 11, 2025
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a fast test / fast integration test to make sure this does not happen again?

@vasqu
Copy link
Contributor Author

vasqu commented Aug 11, 2025

run-slow: gpt_bigcode

@github-actions GitHub Actions
Copy link
Contributor

This comment contains run-slow, running the specified jobs:

models: ['models/gpt_bigcode']
quantizations: [] ...

@vasqu
Copy link
Contributor Author

vasqu commented Aug 11, 2025

run-slow: gpt_bigcode

@github-actions GitHub Actions
Copy link
Contributor

This comment contains run-slow, running the specified jobs:

models: ['models/gpt_bigcode']
quantizations: [] ...

@github-actions GitHub Actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: gpt_bigcode

@vasqu
Copy link
Contributor Author

vasqu commented Aug 11, 2025 •
edited
Loading

Only some parallel tests fail (as in main). Fixed the old regression tests and added a new one that would only produce newlines before this fix - hopefully, this is a "tougher" test so small breaks are easier to detect before.

Will merge after CI is green

@vasqu vasqu enabled auto-merge (squash) August 11, 2025 18:47
@vasqu vasqu merged commit e29919f into huggingface:main Aug 11, 2025
18 checks passed
@vasqu vasqu deleted the fix-gpt-bigcode branch August 11, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmellor hmellor hmellor approved these changes

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
for patch Tag issues / labels that should be included in the next patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vasqu @HuggingFaceDocBuilderDev @hmellor @ArthurZucker