Skip to content

(small) fix conditional for input_ids and input_embeds in marian #40045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cyntqliu
Copy link

@cyntqliu cyntqliu commented Aug 8, 2025

What does this PR do?

This PR fixes a small bug in the conditional in modeling_marian.py. In issue #39542, the issue raiser noticed that both input_ids and input_embeds were none, but that got filtered into the conditional check for both being not None.

Related to but does not fix #39542

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Ran pytest tests/models/marian/test_modeling_marian.py to check for regressions.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @Rocketknight1

Copy link
Contributor

github-actions bot commented Aug 8, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: marian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: You cannot specify both decoder_input_ids and decoder_inputs_embeds at the same time
1 participant