Skip to content

Change Qwen2RMSNorm to RMSNorm from PyTorch #40066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change Qwen2RMSNorm to RMSNorm from PyTorch #40066

wants to merge 2 commits into from

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Aug 10, 2025 •
edited
Loading

What does this PR do?

Use RMSNorm from PyTorch 2.3+.

@cyyever cyyever force-pushed the rmsnorm branch 3 times, most recently from 13cca92 to 513246d Compare August 10, 2025 08:55
@cyyever
Unify Qwen2RMSNorm definitions and use RMSNorm from PyTorch
2ada171 
Signed-off-by: cyy <cyyever@outlook.com>
@github-actions GitHub Actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: dots1, qwen2, qwen2_5_omni, qwen2_5_vl, qwen2_vl, qwen3

@cyyever
subclass RMSNorm
57ff386 
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever cyyever changed the title Unify Qwen2RMSNorm definitions and use RMSNorm from PyTorch Change Qwen2RMSNorm to RMSNorm from PyTorch Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cyyever