Skip to content

tsan: update suppressions #4623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kleisauke
Copy link
Member

@kleisauke kleisauke commented Aug 5, 2025

I noticed that these ThreadSanitizer suppressions were a bit outdated while investigating #4622.

Build notes:

Details
export CC="/usr/bin/clang"
export CXX="/usr/bin/clang++"
export LD="/usr/bin/ld.lld"

export TSAN_DSO=$($CC -print-file-name=libclang_rt.tsan.so)
export TSAN_SYMBOLIZER_PATH=$($CC -print-prog-name=llvm-symbolizer)

export CPPFLAGS="-g -fno-omit-frame-pointer"

export TSAN_OPTIONS="suppressions=$PWD/suppressions/tsan.supp:print_suppressions=1:ignore_noninstrumented_modules=1"

rm -rf build/
meson setup build --prefix=/usr -Ddebug=true -Ddeprecated=false -Dexamples=false -Dmodules=disabled -Dintrospection=disabled -Db_sanitize=thread -Db_lundef=false
meson compile -Cbuild
meson test -Cbuild --timeout-multiplier=0
sudo meson install -Cbuild

LD_PRELOAD=$TSAN_DSO python3 -m pytest -sv --log-cli-level=WARNING test/test-suite > test-suite.txt 2>&1

@kleisauke kleisauke changed the title Update tsan suppressions tsan: update suppressions Aug 5, 2025
@kleisauke kleisauke changed the title tsan: update suppressions tsan: remove obsolete suppressions Aug 6, 2025
@kleisauke kleisauke force-pushed the update-tsan-suppressions branch from 7a8a98e to 5d212d4 Compare August 6, 2025 07:24
@kleisauke kleisauke marked this pull request as draft August 6, 2025 08:04
@dloebl dloebl mentioned this pull request Aug 6, 2025
@kleisauke kleisauke force-pushed the update-tsan-suppressions branch from 5d212d4 to 6679181 Compare August 7, 2025 17:09
@kleisauke kleisauke changed the title tsan: remove obsolete suppressions tsan: update suppressions Aug 7, 2025
@kleisauke
Copy link
Member Author

Test CI run here (using commit kleisauke@e50d2fb):
https://github.com/kleisauke/libvips/actions/runs/16810815668/job/47615389217

For reference, the previous race:vips_threadset_work suppression unintentionally suppressed all reports, since race: matches against all frames in the report stacks.

ThreadSanitizer: Matched 7574386 suppressions (pid=146288):
7574386 race:vips_threadset_work

@kleisauke kleisauke marked this pull request as ready for review August 7, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant