Skip to content

Step Functions: Fix Batch error handling #12988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Step Functions: Fix Batch error handling #12988

wants to merge 1 commit into from
+1 −1

Conversation

nik-localstack
Copy link
Contributor

@nik-localstack nik-localstack commented Aug 11, 2025 •
edited
Loading

Motivation

The error message originally included in the failure event's error message is part of the Batch service's error message format. This shouldn't be handled in the Step Functions handler, but should be part of the Batch service implementation.

Changes

  • Removes extra handling for Batch service errors in StateTaskServiceBatch

@nik-localstack nik-localstack self-assigned this Aug 11, 2025
@nik-localstack nik-localstack added aws:stepfunctions AWS Step Functions aws:batch AWS Batch semver: patch Non-breaking changes which can be included in patch releases labels Aug 11, 2025
@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

22 063 tests  ±0   20 329 ✅ ±0   6m 22s ⏱️ -1s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit ab6427d. ± Comparison against base commit cd7b481.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 23s ⏱️ +16s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit ab6427d. ± Comparison against base commit cd7b481.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   22m 58s ⏱️ - 1h 19m 43s
1 538 tests  - 3 087  1 462 ✅  - 2 724  76 💤  - 363  0 ❌ ±0 
1 540 runs   - 3 087  1 462 ✅  - 2 724  78 💤  - 363  0 ❌ ±0 

Results for commit ab6427d. ± Comparison against base commit cd7b481.

This pull request removes 3087 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   39m 20s ⏱️
1 562 tests 1 487 ✅ 75 💤 0 ❌
1 568 runs  1 487 ✅ 81 💤 0 ❌

Results for commit ab6427d.

@nik-localstack nik-localstack marked this pull request as ready for review August 11, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@MEPalma MEPalma Awaiting requested review from MEPalma MEPalma is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

@nik-localstack nik-localstack

Labels
aws:batch AWS Batch aws:stepfunctions AWS Step Functions semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nik-localstack @joe4dev