mapstruct#3836 sealed interface create impl class with switch #3885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In version 17, the switch statement needs a default return, resulting in an error. If anyone has any branching ideas based on the version, please let me know. |
|
I'll need some time to go through this one @mildw428. I am not sure that we can always use the enhanced |
Thank you for reviewing my code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed it for bug number 3836.
I added sourceArgumentType to know the parameter type of the subclass.
Generates as a switch or if-else syntax according to isSealed().
If you have any issues, please advise.
#3836