fix: test.fixme condition parameter documentation #36977
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavelfeldman 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>
|
It is good that you fixed the test.fixme, but the original problem was with test.skip. Please keep the change for test.fixme and add a similar change for test.skip. |
Copilot finished work on behalf of
pavelfeldman
August 11, 2025 01:12
mxschmitt
approved these changes
Aug 11, 2025
yury-s
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
test.fixme()condition and callback parameters incorrectly described the behavior as "should fail" when it should describe "fixme" behavior. This was a copy-paste error where thetest.fixmedocumentation accidentally used descriptions fromtest.fail.Before:
After:
The issue was present in both the markdown documentation (
docs/src/test-api/class-test.md) and the generated TypeScript definitions (packages/playwright/types/test.d.ts).Changes made:
test.fixme.conditionparameter description to correctly reference "fixme" behaviortest.fixme.callbackparameter description to correctly reference "fixme" behaviortest.skipandtest.faildocumentation remains accurate and unchangedAll documentation linting and type checking tests pass with these changes.
Fixes #36976.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.