Add credentials environment variables to let ChannelCredentials and Session be injected
#4689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
reviewed
Jul 18, 2025
xrmx
reviewed
Jul 21, 2025
| @@ -202,12 +245,43 @@ def _get_exporter_names( | |||
| ] | |||
|
|
|||
|
|
|||
| def _init_exporter( | |||
| signal_type: Literal["traces", "metrics", "logs"], | |||
| exporter_args_map: Mapping[str, Any], | |||
There was a problem hiding this comment.
exporter_args_map has been used consistently with the type ExporterArgsMap, I'll just call this exporter_args since this is already for a specific exporter.
There was a problem hiding this comment.
Ack good point, switched it out for ExporterArgsMap // exporter_args
There was a problem hiding this comment.
Sorry, I meant to only change the name. The type was fine.
| @@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Overwrite logging.config.fileConfig and logging.config.dictConfig to ensure | |||
| the OTLP `LogHandler` remains attached to the root logger. Fix a bug that | |||
| can cause a deadlock to occur over `logging._lock` in some cases ([#4636](https://github.com/open-telemetry/opentelemetry-python/pull/4636)). | |||
| - Add new environment variables to the SDK `OTEL_PYTHON_EXPORTER_OTLP_{METRICS/TRACES/LOGS}_CREDENTIAL_PROVIDER` that can be used to | |||
| inject a `requests.Session` or `grpc.ChannelCredentials` object into OTLP exporters created during auto instrumentation. | |||
There was a problem hiding this comment.
Just need to link this PR
Suggested change
| inject a `requests.Session` or `grpc.ChannelCredentials` object into OTLP exporters created during auto instrumentation. | |
| inject a `requests.Session` or `grpc.ChannelCredentials` object into OTLP exporters created during auto instrumentation ([#4689](https://github.com/open-telemetry/opentelemetry-python/pull/4689)). |
|
|
||
| from grpc import ChannelCredentials # pylint: disable=import-error |
There was a problem hiding this comment.
Could this be an issue if the SDK is running in an environment without grpcio installed? I know the operator auto-instrumentation layer for Python pre-installs the HTTP exporters and not the grpc exporters to avoid extension issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add environment variables to allow
ChannelCredentialsandSessionto be injected into OTLP exporters for auto instrumentation. See #4459 for more details..Fixes # 4459
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: