Skip to content

Fix sporadic macOS 14 CI failure #28187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sporadic macOS 14 CI failure #28187

wants to merge 1 commit into from

Conversation

andrewkdinh
Copy link
Contributor

quic_tserver_test would fail sporadically when using thread_assist mode along with fake_time, specifically on macos-14 machine.

This PR gives the server more opportunities to process events to keep the it connected to the client while still maintaining the original 60s idle timeout period for the test.

I can't say this will definitely solve the issue, but I was able to confirm that doing the opposite caused the test to fail more often. e.g. when I changed fake_time + OSSL_sleep to increment in intervals of 1000ms, the same test failed much more often. I have run make test with my changes 50+ times to confirm that the test now consistently passes: https://github.com/andrewkdinh/openssl/actions/runs/16783870352

Fixes openssl/project#1290

Checklist
  • tests are added or updated

paulidale
paulidale approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a try.

Sashan
Sashan approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@Sashan Sashan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatever helps here is fine with me. thanks for clarifying note.

Sashan
Sashan requested changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@Sashan Sashan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we wait with integration of this change for a while. I think we should let in PR from @esyr first, because it might actually help here.

#28193

@andrewkdinh
Copy link
Contributor Author

Ok, we will merge in PR #28193 first. If that doesn't resolve the issue, then we can merge this PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sashan Sashan Sashan requested changes

@nhorman nhorman nhorman approved these changes

@paulidale paulidale paulidale approved these changes

@esyr esyr Awaiting requested review from esyr

@mattcaswell mattcaswell Awaiting requested review from mattcaswell

@jogme jogme Awaiting requested review from jogme

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate quic tserver test failure
4 participants
@andrewkdinh @Sashan @nhorman @paulidale