crypto\cms\cms_kem.c: Add ASN1_TYPE_free when EVP_CIPHER_param_to_asn… #28210
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogme
approved these changes
Aug 11, 2025
t8m
requested changes
Aug 11, 2025
crypto/cms/cms_kem.c
Outdated
Comment on lines
138
to
141
| if (EVP_CIPHER_param_to_asn1(kekctx, wrap->parameter) <= 0) | ||
| ASN1_TYPE_free(wrap->parameter); | ||
| wrap->parameter = NULL; | ||
| goto err; |
There was a problem hiding this comment.
You did not add {} around the intended block!
There was a problem hiding this comment.
Also I think the subsequent ASN1_TYPE_get() check actually does what this is fixing.
There was a problem hiding this comment.
Also I think the subsequent ASN1_TYPE_get() check actually does what this is fixing.
When EVP_CIPHER_param_to_asn1() fails, jump directly to the err label. So the subsequent ASN1_TYPE_get() check does not work.
…1() fails Signed-off-by: Nachel72 <Nachel72@outlook.com> CLA: trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…1() fails
Fixed a memory leak caused by wrap->parameter not being freed.
CLA: trivial